kolbasa/cordova-plugin-apkupdater

isDeviceRooted not working correctly

Closed this issue · 5 comments

image

When i call isDeviceRooted() on some devices i get true but when i try to install then with root i am getting a catch with the error that the Device is not rooted. I can say that the Firmware is singed with test keys. I am not sure if this helps.

Maybe we can find a different root detection.

Hmm. I was afraid of something like that. I wanted to have a minimal solution to test the root status. I guess this is not enough. The root methods are often very different.

I'll have to include something like that: https://github.com/scottyab/rootbeer

Give me 1 or 2 days, I'll test it out.

Hmm. I was afraid of something like that. I wanted to have a minimal solution to test the root status. I guess this is not enough. The root methods are often very different.

I'll have to include something like that: https://github.com/scottyab/rootbeer

Give me 1 or 2 days, I'll test it out.

If you have something to test send it over.

isDeviceRooted() now uses the rootbeer library.

The change is now on the branch: root-tools:
cordova plugin add https://github.com/kolbasa/cordova-plugin-apkupdater#root-tools

Change is published with version: 2.5.0

isDeviceRooted() now uses the rootbeer library.

The change is now on the branch: root-tools:
cordova plugin add https://github.com/kolbasa/cordova-plugin-apkupdater#root-tools

Change is published with version: 2.5.0

It does work now correctly.

Glad to hear that. Let me know if you find anything else. 👍