kolodny/jsan

Skip data which throws on `value.toJSON`

Closed this issue · 3 comments

zalmoxisus commented

To skip data we don't have access to, we could add a try-catch in

jsan/lib/cycle.js

Line 87 in 6386071

value = value.toJSON(key);

It would solve issues like zalmoxisus/redux-devtools-extension#407, but not sure it's good to swallow exceptions.

kolodny commented

@zalmoxisus Can you provide a simple example to reproduce the error, I can't seem to cause an error to happen

kolodny commented

I published v3.1.10 which should catch these errors from now on. Let me know if that works.

kolodny commented

Closing for now, feel free to reopen if the problem persists