minifb no longer compatible

[MagaTailor]

I guess the function signature must have changed recently. What's the last compatible version?

Compiling rust64 v0.0.1 (file:///tmp/rust64-master)
src/c64/mod.rs:52:72: 52:81 error: mismatched types:
 expected `minifb::WindowOptions`,
    found `minifb::Scale`
(expected struct `minifb::WindowOptions`,
    found enum `minifb::Scale`) [E0308]
src/c64/mod.rs:52             window: Window::new("Rust64", SCREEN_WIDTH, SCREEN_HEIGHT, Scale::X1).unwrap(),
                                                                                         ^~~~~~~~~
src/c64/mod.rs:52:72: 52:81 help: run `rustc --explain E0308` to see a detailed explanation
src/c64/mod.rs:176:29: 176:35 error: this function takes 0 parameters but 1 parameter was supplied [E0061]
src/c64/mod.rs:176                 self.window.update(&self.vic.borrow_mut().window_buffer);
                                               ^~~~~~
src/c64/mod.rs:176:29: 176:35 help: run `rustc --explain E0061` to see a detailed explanation
src/debugger/mod.rs:37:73: 37:82 error: mismatched types:
 expected `minifb::WindowOptions`,
    found `minifb::Scale`
(expected struct `minifb::WindowOptions`,
    found enum `minifb::Scale`) [E0308]
src/debugger/mod.rs:37             debug_window: Window::new("Debug window", DEBUG_W, DEBUG_H, Scale::X2).unwrap(),
                                                                                               ^~~~~~~~~
src/debugger/mod.rs:37:73: 37:82 help: run `rustc --explain E0308` to see a detailed explanation
src/debugger/mod.rs:38:79: 38:88 error: mismatched types:
 expected `minifb::WindowOptions`,
    found `minifb::Scale`
(expected struct `minifb::WindowOptions`,
    found enum `minifb::Scale`) [E0308]
src/debugger/mod.rs:38             raster_window: Window::new("VIC", RASTER_DEBUG_W, RASTER_DEBUG_H, Scale::X1).unwrap(),
                                                                                                     ^~~~~~~~~
src/debugger/mod.rs:38:79: 38:88 help: run `rustc --explain E0308` to see a detailed explanation
src/debugger/mod.rs:103:31: 103:37 error: this function takes 0 parameters but 1 parameter was supplied [E0061]
src/debugger/mod.rs:103             self.debug_window.update(&self.window_buffer);
                                                      ^~~~~~
src/debugger/mod.rs:103:31: 103:37 help: run `rustc --explain E0061` to see a detailed explanation
src/debugger/mod.rs:107:32: 107:38 error: this function takes 0 parameters but 1 parameter was supplied [E0061]
src/debugger/mod.rs:107             self.raster_window.update(&self.raster_buffer);
                                                       ^~~~~~
src/debugger/mod.rs:107:32: 107:38 help: run `rustc --explain E0061` to see a detailed explanation
error: aborting due to 6 previous errors
Could not compile `rust64`.

[kondrak]

There's been an API change in minifb 0.4.0, master branch is fetching the latest but I haven't updated the code yet. I'm currently working on major changes on new_cpu branch, I'll cherry-pick the necessary commits tomorrow. For now, you can switch to minifb 0.3.0.

[MagaTailor]

Ok thx, the "*" dependencies are always risky.

[kondrak]

Yeah I'll be dropping the asterisk for all dependencies. Odd that neither appveyor nor travis caught this, though!

[MagaTailor]

Interesting! Probably some sort of caching and never touching Cargo.lock or sth.

[kondrak]

I cherry-picked the necessary changes to master, should be working now.

[MagaTailor]

Indeed it does.