Rebranding to Kentico Kontent
petrsvihlik opened this issue · 21 comments
Hi @aweigold !
We've just renamed Kentico Cloud to Kentico Kontent. We are in the process of renaming all SDKs, developer tools, and sample apps. Please consider renaming your project (code: namespaces, classes; repo, wiki, GH topics, etc.) to Kentico Kontent. See the guidelines at https://gitter.im/Kentico/Kontent?at=5d8b643d692d464f7969c6d9.
Thank you!
This should largely be done. Remaining issue is to reach out to sonatype to allow publishing to kentico.kontent instead of com.kenticocloud in the Maven central snapshot and release repositories.
This can usually be done via their Jira system, but would probably be streamlined if someone working from Kentico can perform it.
They may not allow kentico.kontent, in which case, I would recommend publishing to ai.kontent as they can verify that domain ownership.
Note, publishing to ai.kontent will not reflect on package names. They can remain kentico.kontent per the guidelines posted in gitter.
Assigning this to @petrsvihlik to triage on his end. Once this is complete, you can assign back to me and I'll complete the 3.0.0 release process.
FYI, I did confirm before renaming that the CI was functioning and publishing successfully to Maven Central's snapshot repository: https://oss.sonatype.org/content/repositories/snapshots/com/kenticocloud/delivery/3.0.0-SNAPSHOT/
I created a request at https://issues.sonatype.org/browse/OSSRH-52022 and I'm reassigning this task to @Simply007 as I'll be off for the whole of October.
Please coordinate the rebranding and the release of the new version with him.
Thank you!
https://issues.sonatype.org/browse/OSSRH-52104
@Simply007 @aweigold please guys, take over from here.
Hello @aweigold,
petrs (@petrsvihlik) should be already granted by com.github.kentico (https://issues.sonatype.org/browse/OSSRH-52104).
If you have anything to discuss, feel free to content me here on you use Gitter: https://gitter.om/Simply007
Is there anything I could help you with right now?
I'll work on a release tonight, and update here.
Update:
I tried publishing to the new group name via travis (https://travis-ci.org/Kentico/kontent-delivery-sdk-java/builds/595577983), and my user (aweigold) did not have deploy privileges. I commented on the sonatype ticket (https://issues.sonatype.org/browse/OSSRH-52104).
Thank for info
OK, I have subscribed to the ticket updates. If they want to authenticate you again by creating some repo, I could do it for you.
Now you should be able to publish the package.
I attempted to publish yesterday morning, but due to issues with oss.sonatype.org being overloaded and timing out, I had to delay it. I'll make another attempt tonight.
All right - wish you good luck!
Released on central. I'll look in a few hours to validate it's propagating, and close.
Looks like it's released:
https://repo.maven.apache.org/maven2/com/github/kentico/delivery/3.0.0/
Great @aweigold!
I have just one question about artifactId. You have set it as delivery. Wouldn't be better to set it to kontent-delivery to have the package identification like that: com.github.kentico:kontent-delivery:3.0.0?
I don't know if artifactId should be bound to the package namespace (kentico.kontent.delivery), but it feels better from my point of view to have them somehow similar.
We have used kontent in package names to distinguish kontent and ems packages and to prevent confusion (i.e. JS SDK PHP SDK) with EMS packages.
I don't know what are the options since the package is already released - what do you think about that?
As far as renaming delivery to kontent-delivery, that is no problem. I can make a commit and do a new release.
As far as the package groupId, that is bound to what we have rights to deploy to on Maven Central. Sonatype requires this to be a domain controlled by the organization. Hence why it's com.github.kentico. If desired, this could be ai.kontent if the domain is validated, but that's it.
As far as the package namespace matching the groupId... I tend to agree, but was following the guidance from the gitter thread. I'll leave it to you @Simply007 on which way to go on that one.
After I hear back on the package namespace to groupId inconsistency, I will push another release to rename to kontent-delivery.
OK let's leave the namespaces as they are and set the groupId to kontent-delivery.
Thank you so much @aweigold!
@aweigold I am updating the code samples for our documentation. There is not a consensus on our side for what should replace import com.kenticocloud.delivery at the beginning of each sample in our API reference. Can you let me know what it should be?
@MikeSvacha the package to import is kentico.kontent.delivery.
According to the API changelog there should be new endpoints set in the SDK.
@aweigold
There are still old domains for delivery as well as preview that will stop working by the end of March 2020.
There are also other remaining occurrences of the old names - mainly API reference URLs in the JavaDoc:
https://github.com/Kentico/kontent-delivery-sdk-java/search?q=kenticocloud&unscoped_q=kenticocloud
There are still some occurrences of "Kentico Cloud" in the code: https://github.com/Kentico/kontent-delivery-sdk-java/search?q=cloud&unscoped_q=cloud
https://github.com/Kentico/kontent-delivery-sdk-java/blob/master/kontent-delivery/src/main/java/kentico/kontent/delivery/DeliveryOptions.java#L63
We need to address this asap.
Should all be fixed.