Argument documentation doesn't match arguments
daviddoria opened this issue · 3 comments
daviddoria commented
In these files:
https://github.com/koraykv/unsup/blob/master/SpatialConvFistaL1.lua
https://github.com/koraykv/unsup/blob/master/ConvPsd.lua
the documentation has 'inputFeatures' and 'outputFeatures', but these are not arguments to the function. The function also has the argument 'conntable', which is not described.
koraykv commented
contable is a connection table that is fed into nn.SpatialConvolutionMap (https://github.com/torch/DEPRECEATED-torch7-distro/blob/master/extra/nn/SpatialConvolutionMap.lua). There are examples and functions in 'nn' to create these tables.
daviddoria commented
The documentation in these files was not changed - shouldn't the issue stay open until it is?
koraykv commented
just did. thanks.