NTS-1 mkII: The LED shows a wrong string value after scrolling starts
boochow opened this issue · 4 comments
boochow commented
There is a problem in displaying strings of type k_unit_param_type_strings
.
(1)Values of 4 or less characters and values of 5 or more characters are mixed in the string returned by getParameterStrValue()
.
(2)A value of 5 or more characters had been selected even once.
(3)A value of 4 or less characters is currently selected.
When the above conditions are met, the last selected value of 5 or more characters is displayed after scrolling starts.
// example: "SQUARE" is always displayed as a scrolling string.
inline const char * getParameterStrValue(uint8_t index, int32_t value) cons\
t {
if (index == 2) {
if (value == 0) {
return "SINE"; // = 4 chars
} else {
return "SQUARE"; // > 4 chars
}
} else {
return nullptr;
}
}
AndrewCapon commented
boochow commented
@AndrewCapon I made all strings to be longer than four characters :-)
AndrewCapon commented
:)
Nice one, I will do the same.
boochow commented
I tested firmware v1.2 and can confirm that this issue has been fixed.