Missing package in Long.kt file

Question

Missing package in Long.kt file

SerVB opened this issue 7 years ago · 3 comments

Hello!

There is no package unsigned here: https://github.com/kotlin-graphics/kotlin-unsigned/blob/master/src/main/kotlin/unsigned/Long.kt.

Is it made on purpose or is it a bug? ;)

Answer 1 · 2018-07-10T11:15:06.000Z

Definitely a bug, thanks

Answer 2 · 2018-07-10T11:29:51.000Z

You are welcome. Actually, your commit is not enough. There are many imports from default package (for example, in tests). Now the project doesn't compile and tests don't pass.

Could you check my commit out?

https://github.com/SerVB/kotlin-unsigned/commit/2827d744ba3f783a5559df6f27d595fe559d15c4

I can make a PR if you like.

Answer 3 · 2018-07-10T11:32:02.000Z

I'm not at dev pc now, your pr is very very welcome