koulanurag/ma-gym

Off by one error

aswin-raghavan opened this issue · 1 comments

aswin-raghavan commented

ma-gym/ma_gym/envs/predator_prey/predator_prey.py

Line 118 in 1c94623

_agent_i_obs = [pos[0] / self._grid_shape[0], pos[1] / (self._grid_shape[1] - 1)] # coordinates

_agent_i_obs = [pos[0] / self._grid_shape[0], pos[1] / (self._grid_shape[1] - 1)] # coordinates
Should be
_agent_i_obs = [pos[0] / (self._grid_shape[0] - 1), pos[1] / (self._grid_shape[1] - 1)] # coordinates

koulanurag commented

Hi @aswin-raghavan,
Thanks for finding this bug. I would be happy to receive a PR on this.

Note for others : This is a normalization factor to get the position coordinates in the range of [0,1]. In the current state, It's off by 1 which would give us position coordinates in the range of [0,0.8]. Implying, we still had one to one mapping from normalized form to actual position coordinates justifying the trainability of the agents. At the same time, it should be normalized in the correct range as suggested.