kovshenin/sail

Profiler should not allow redirects

Closed this issue · 0 comments

When running a request through the profiler, the X-Sail-Profile response header is lost between redirects and no results are fetched. We shouldn't follow any redirects during profiling requests. Example:

sail profile https://example.org/favicon.ico # redirects to default WP favicon

Fails with:

Error: X-Sail-Profile header not found in response. Check your profile key.

Can probably be solved using allow_redirects in Requests, which defaults to True: https://2.python-requests.org/en/master/api/#requests.Session.request