Add lawful `Semigroup` and `Monoid` instances to `Treap` and `RTreap`

Question

Add lawful `Semigroup` and `Monoid` instances to `Treap` and `RTreap`

chshersh opened this issue 5 years ago · 3 comments

I think merge can be an implementation of <>.

Answer 1 · 2019-05-06T18:14:28.000Z

@chshersh do you mind if I take this?

Answer 2 · 2019-05-07T02:55:10.000Z

@sphaso Sure, go for it! It would be also nice to implement property-based testing for Semigroup and Monoid laws. But we have separate issue for that: #24. Let me know if you want to implement these two property-tests as well 🙂

Answer 3 · 2019-05-07T18:20:56.000Z

@chshersh great idea! I opened a PR which includes a couple of property-based tests.