kpchoy/HypeCamp

PA Review: User Authentication

Closed this issue · 3 comments

kpchoy commented
  • User can sign up, login, logout
  • User can demo login on site
  • Styling
andywynkoop commented

Hey Kevin,
Everything for user auth is looking great so far! Here are a few changes to make:

  • Remove redux logger and all console logs from production
  • Based on the message I get in the console, it looks like the buttons to navigate between sign up and log in are nested inside of a form, they should probably be moved into their own element so they don't trigger form submission
  • Logo should be clickable and redirect to /
  • Start hosting button should probably do something, maybe open the sign up modal?
  • Need working demo login
  • If I visit a random route, /ssdfsadfsadsadfgvr/, I should get either a 404 page or be redirected back to /
  • Errors should clear when going between sign up and log in pages
  • Errors should also clear when I close and re-open the modal
  • Start hosting, log in, and sign up should have cursor: pointer on hover
kpchoy commented

Hey andy when you ahve time can you help me with the last parts of my user auth, thanks

andywynkoop commented

👍