kprotty/usync

MSRV?

palfrey opened this issue · 4 comments

What's the minimum stable Rust version supported by this library? I've dug through the docs a bit and hadn't spotted any mention of a version.

Not sure. How would one go about figuring this out? It requires std::arch::asm stabilization for x86 targets if that helps.

Uh, there's probably more sophisticated ways to do so, but for serial_test I mostly just tested with various Rust versions, and then added a CI check to make sure the declared MSRV still kept working.

Although https://doc.rust-lang.org/stable/core/arch/macro.asm.html does say 1.59.0, so that's probably a good place to start :)

Hm, 1.59.0 builds fine. It seems to reliably cause a double-panic issue in the test suite that I thought had only shown up under sanitizers, though.

That probably is just an issue with the test, and not something that impacts actual usage, although I can't say that with total certainty.

#11 adds a test/badge for 1.59.0, but I'm also seeing a test issue locally.