Keep multiplication pure

Question

Keep multiplication pure

Closed this issue 5 years ago · 4 comments

The multiply code should take a template argument for what it does with C. If there's a postprocess pipeline implemented using that template argument, fine. But the multiplier (i.e. multiply.h) should not impose that on users.

Answer 1 · 2019-07-09T17:25:41.000Z

wip branch: https://github.com/kpu/intgemm/tree/callbacks-and-kernels

Answer 2 · 2019-07-10T09:42:28.000Z

Cool. I think dvector_t is overkill. We could just have multiply call the callback twice. Or use std::pair.

Answer 3 · 2019-07-16T12:35:41.000Z

Branch "callbacks and kernels" has been merged.

Answer 4 · 2019-08-30T15:39:51.000Z

Do we want to do something more in this issue or we can close it?