kr/ct

ctcheck should have an option to output benchmarks only

ysmolski opened this issue · 6 comments

Right now_ctcheck outputs tests results as well. But I propose it to return just the benchmarks to allow measuring with benchstat. It should be allowed to run benchmark suite N times too.

Originally posted by in beanstalkd/beanstalkd#506 (comment)

Hmm, just tried this version and it is not so handy when I write some code that timeouts or behaves slow in tests. I have no indication of the progress... It would be better to keep the progress and completely disable testing in the case of -bench or some different switch. Sorry for not making myself clear before.

I can disable testing this way:
ct/_ctcheck -test '' -bench '*'

kr commented

Yeah, if you want to skip the tests it’s best to use -test ''.

I don’t want -b or -bench to affect which tests will run. Tests and benchmarks imo should be controlled orthogonally.

kr commented

(Or of course you can use -test . or any other value that matches none of the test names.)

kr commented

Would you prefer I revert 80f0155 then? I’m happy either way on that.

Yes, please, revert would be the most wanted.