no way to easily get a defaulted config

Question

no way to easily get a defaulted config

jmhodges opened this issue 11 years ago · 6 comments

DefaultConfig is nice, but since it's a pointer to the struct, there's no trivial way of cloning it locally and modifying it.

Making DefaultConfig not a &Config{}, but just a Config{} would allow users to quickly clone and customize the DefaultConfig when they are not able to use the default muxer. (Otherwise, race conditions occur.)

Alternatively, a nice factory function NewConfig() would be good.

Answer 1 · 2013-09-09T07:08:20.000Z

(Yes, you can play tricks with pointer dereferencing, but that's not great.)

Answer 2 · 2013-10-25T01:04:41.000Z

Writing var x = *secureheader.DefaultConfig seems pretty trivial.

Answer 3 · 2013-10-26T08:22:29.000Z

That trick is not guaranteed to work if objects inside are complex enough and have modifications made to them on other goroutines. It's something I don't think we'd want developers to normalize around. Adding a function seems to be a trivial to avoid that.

Answer 4 · 2013-10-26T23:50:06.000Z

Defining DefaultConfig with Config{…} rather than &Config{…} is the same trick,
but I don't want to break existing programs.

This is safe because DefaultConfig doesn't contain any pointers.

Answer 5 · 2013-10-26T23:56:28.000Z

Also, what are you actually trying to do here?
Can you give an example?

Regardless of whether or not you use http.DefaultServeMux,
changing secureheader.DefaultConfig doesn't require copying it.

Answer 6 · 2016-08-29T11:58:55.000Z

Closing because old and that's fine