💡 [FEAT] Decrease navbar height when the terminal is zoomed in
enderprism opened this issue · 7 comments
Is your feature request related to a problem? 😢 Please describe.
I zoom in my terminal emulator to make the words easier to read (and to make it closer to Monkeytype). I know having separate font sizes for the words and other TUI elements isn't possible since we're in a terminal.
Small text
The text is the right size but the navbar is really tall
Describe the solution you'd like 🤔
Make a small version of the logo and decrease the navbar height when the terminal is zoomed in (aka few columns).
Describe alternatives you've considered 🧐
Don't zoom in, or live with the tall header
Additional context 📝
Operating system
EndeavourOS
Terminal emulator
Konsole
Smassh version
smassh --version crashes
I just noticed another bug wow
$ smassh --version
Traceback (most recent call last):
File "smassh.py", line 2, in <module>
File "click/core.py", line 1157, in __call__
File "click/core.py", line 1078, in main
File "click/core.py", line 1666, in invoke
File "click/core.py", line 1434, in invoke
File "click/core.py", line 783, in invoke
File "click/decorators.py", line 33, in new_func
File "smassh/__init__.py", line 20, in main
File "importlib/metadata/__init__.py", line 996, in version
File "importlib/metadata/__init__.py", line 969, in distribution
File "importlib/metadata/__init__.py", line 548, in from_name
importlib.metadata.PackageNotFoundError: No package metadata was found for smassh
[223112] Failed to execute script 'smassh' due to unhandled exception!
smassh AUR package version: 3.0.3-1
I see. Makes sense!
Ah yes, I need to fix the versioning issue for binary packages. I haven't found any good solution yet so I'm thinking of hardcoding it. I will push a fix! :)
Hey @enderprism, I've been trying to implement this thingy and I have a good POC now.
what do you think? Is it similar to what you suggested?
Also, I think I should hide hide all the unnecessary things when the typing starts :)
Before:
After:
it looks exactly like i wanted! maybe still make the header hand some margin at the top and bottom (1 line only's good) because it looks a bit cramped
or maybe add an option to add additional navbar height when zoomed in? i havent tested it yet so i can't tell
it looks a bit cramped
I agree. But I think it might be due to the background color as well, Maybe I can get rid of that (but this seems too odd)
i haven't tested it yet so i can't tell
Right. I'll push it to dev branch.
How did you install it?
Hey @enderprism !
Ok here's the new one:
I'm not sure when to resize the bar. Currently, it resizes when the number of rows in the terminal screen is 30
That's 1:6 to the terminal or 1:5 compared to the typing space
i'll try it asap