Add ability to download log files from UI
krakenrf opened this issue · 5 comments
Note for future work. Will be useful for customer debugging.
Maybe just a symlink to them will work in _share?
@krakenrf Links from shared folders are considered to be bad security's practices. Maybe we can create a logs sub folder inside _share and write there directly?
Hm but we also need to be able to get the logs out from the heimdall Firmware/_logs folder, and I don't think it's a good idea to make heimdall write it's logs to the krakensdr_doa/_share folder, since heimdall can be run standalone without krakensdr_doa.
Perhaps there needs to be a script that periodically copies the logs over. But security wise, what's the difference between a symlink to the logs in another folder, vs copying/writing them directly?
Also just noting if we're thinking about security, the way Local Data Recording is downloaded will need looking at too, since it's possible to traverse the directory structure via the filename and download anything. Probably just got to sanitize ../