Example
Opened this issue Β· 91 comments
Demo.
Octomments is a comment plugin based on GitHub issues. Try posting a comment below.
I think it looks awesome.
rilly?
Ah so we have a second comment appearing. It looks like it is indeed working :D
Let's try some emojis π₯ π― π¨
ok it's good
Testing
Are all these permissions are necessary to allow log-in + comment? I donβt plan to dig and read GitHub permissions doc, but it should raise people attention.
This is a cool idea! But on a (mostly) unrelated tangent:
in your page's
<head>tag:
Why even use <head> tags, especially if you care about performance?
Google's own guidelines now encourage you to do what the HTML spec has said was ok for awhile now: leave <html>, <head>, and <body> tags out of your HTML.
They add nothing except page weight, as every browser will infer them, and treat the page identically whether they are there or not.
Now, we're talking a tiny number of characters in the grand scheme, so it's not a meaningful performance enhancement .. but again, there's zero benefit to including those tags today.
Suggestion, change "number" to "issueNumber" so people know what it represents.
Add documentation on how to resolve/approve or reject comments. I don't know if that would be adding a thumbs-up or thumbs-down and filtering on those or providing a method of deleting comments (if possible).
I also assume this allows all of the github markdown, which is pretty cool.
Didn't read LUL
test
var x = []wat
This is a cool idea! But on a (mostly) unrelated tangent:
in your page's
<head>tag:Why even use
<head>tags, especially if you care about performance?Google's own guidelines now encourage you to do what the HTML spec has said was ok for awhile now: leave
<html>,<head>, and<body>tags out of your HTML.They add nothing except page weight, as every browser will infer them, and treat the page identically whether they are there or not.
Now, we're talking a tiny number of characters in the grand scheme, so it's not a meaningful performance enhancement .. but again, there's zero benefit to including those tags today.
Where do they suggest this? Would love to read more!
This is cool! This very comment you are reading has been submitted, and then later edited! On GitHub this comment is set to hidden; The comment is not being hidden in the thread though.
I have wrriten one myself for integrating Gitbook under GitHub or Gitlab, gitbook-comments.
Where do they suggest this? Would love to read more!
https://google.github.io/styleguide/htmlcssguide.html#Optional_Tags
Thank you all for the comments. I'll soon release a new version that addresses the problems mentioned above.
Awesome !
fmt.Println("Testing")
Testing
-
Testing No.1
-
Testing No.2
test
Nice
this is test
Good job ππ
Sweet!
What permissions does this require on my account?
turns out, a lot of them
Really good idea you had ππ
Good idea!
@meduzen @garyjohngoofer Octomments now uses less permissions from the commenters. However the owner of the site should install Octomments app. Which I think is fare.
@ajbogh number changed to issueNumber (thanks for the suggestions. It totally make sense).
Testing with markdown
εεδΈη
This looks awesome
Hello world
Test
This looks awesome
Wow, I'm loving it.
Good idea!
test
Awesome!
Very creative!
woahh
Hola
Alas! Without github account one can not comment. :)
test again
@tamimibrahim17 yep. I have a plan for that.
It might be useful
Interesting
duh, awesome!!! <3
Awesome!
test
This looks useful!!
Nice! Let me try some markdown:
- test
- test2
console.log("Hello, World")Wow
nice!!
@meduzen @garyjohngoofer Octomments now uses less permissions from the commenters. However the owner of the site should install Octomments app. Which I think is fare.
Fantastic! I have another question regarding users permissions:
What does the Actions and Resources permission level allow in Octocomments? Thatβs not clear for me while looking in both Octocomments code and the GitHub API doc.
@meduzen not clear for me either. I searched for that in GitHub docs but didn't find any explanation. I guess the owner of the app should just say what the app is doing.
Super interesting, the manual mapping to a repo/issue for each comment thread might pose a problem. But I can probably automate that too.
@sheharyarn that's exactly what I did. Checkout https://github.com/krasimir/octomments/tree/master/server it provides a quick solution for that.
testing
good
Where was this all this time π₯
dafadsf
Hello there
Hey folks,
I was wondering ... is any of you actually using Octomments and do you have some feedback on the user experience? Are your readers posting stuff?
Hi, I like it.
Test
Another test
jhjhj
Test
Test link
Π°Π²ΠΏΠ²
hmmm..
testing to see if .mov files work
gondola.mov
dfsdfsdfsdfa
It's unique comment system' Like Disqus and Facebook
Good
Is it safe to assume non-devs would be comfortable using this?
@krasimir ocs.now.sh been redirected to ocs.vercel.app and now the login does not work because the redirect_uri_missimatch, any update?
Sorry @jwenjian, I thought that I fixed it couple of days ago. It should be fixed now.
Yes, it works!
π
hmm nice
testing 17.06.2021
testing again
Love it
Teste
testing
Super!