Refactor for Docker
uthopiko opened this issue · 0 comments
uthopiko commented
Now we have fully functional docker upstart created with shell script, but it seems that it is possible to make this better according to the best practices of Docker. For make this refactor, there are some parts:
- Change user in PHPCli to www-data for avoid to create cache files with docker user (root in our case, probably not a very good practise, i am searching info about this)
- Change shell script provision commands to build or to entrypoint
- (#322) In instead of
docker-compose exec php bash -c "echo '172.18.0.10 identityaccess.localhost' >> /etc/hosts"
use https://docs.docker.com/compose/compose-file/#/extrahosts - Look for approach to reuse common constants in all configuration files (For Example: Ip's)
- Look for approach for avoid hardcoding URL's (Config.js)