krharsh17/barview-android

Allow the use of local colors of app in color.xml folder of app.

Closed this issue · 12 comments

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

We should allow users to use the local colors from the color.xml folder of the app.
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Thanks for opening your first issue here! Be sure to follow the issue template!

Can I work on this issue?

Hey @prince-09 ! Can you clearly describe the issue ? Do you want to add some particular colors in color.xml that should be used everytime ?

Yes If user has some colours in color.xml then he should be able to choose that colour by @color/xyz like we have in text view or edittext.

Isn't it possible with the current code in the library?

no, it is not possible with the current code.

@prince-09 so basically you want to add some hex codes of colors in color.xml file?
I am not sure if I got your point correctly?
cc @krharsh17

Clarify the issue here and if seems good it will be assigned to you! @prince-09

Yeah, I too don't seem to fully understand the issue, maybe some examples might help? @prince-09

Screenshot (190)
Screenshot (191)
In background attribute we have @color/colorPrimary option... but we are not getting it in labelTextcolor attribute.

Alright, please make a fix for it!

What's the status on this @prince-09 ?