kribblo/node-ffmpeg-installer

Request for ARM support

bartbutenaers opened this issue · 8 comments

Hi Kristoffer (@kribblo),

When I try following code on a Raspberry Pi 3 Model B (running Raspbian):

    const ffmpeg = require('@ffmpeg-installer/ffmpeg');
    console.log(ffmpeg.path, ffmpeg.version);

Then the result is "Unsupported platform/architecture: linux-arm".

Do you have plans to support ARM processors?
Perhaps following information allows you to determine whether it is possible or not:

  • Seems that Debian supports 3 ports of ARM hardware (armhf / armel / arm64), where both armhf and armel are 32-bit.
  • I found two ways to determine the hardware: see 1 and 2.
  • And here there are binaries available for armhf/armel/arm64.

Thanks for your time !!
Bart

No plans as such, but not opposed to it either! You have already done some of the research I see. If you like to do a pull request it would be even faster, otherwise I will look into it

Wow, that was fast ;-)
Glad to hear that you are not against it ...
Just saw on the link where you fetch your binaries, that armhf/rmel/arm64 binaries are also available. So we can already forget about my link, to keep your code more consistent!
If you would have some time left to implement it, that would be highly appreciated! Otherwise I will try to create a pull request. But that might take a bit longer, since I'm not experienced with debugging such installer code ...

Hello, I created pull request ;)
#29

Hello, I've merged and published, it took a while because npmjs decided to be a #¤%& about the email I already verified. I haven't tested it yet, but should be at version 1.0.18. See if it works for you. :)

Hello,

Thanks;)

Yes, works perfect.

Tested in Raspberry Pi 3 Model B Plus Rev 1.3 on Raspbian Stretch .

Great, closing this then. Thanks!

Ah, one more thing: could you provide the download sources as with the others for the README?