Transaction size calculation for bech32 addresses is likely wrong
Closed this issue · 1 comments
kristapsk commented
$ ./ricochet-send-from.sh -testnet 2N49tbnjF1bxi7CBkB6QeFuY5GV9gRPgFiJ tb1qnmplzth603jf4dhkyk7ptr90whvycncc7e4kx6 2
Ricocheting from 2N49tbnjF1bxi7CBkB6QeFuY5GV9gRPgFiJ (0.01000455 BTC) to tb1qnmplzth603jf4dhkyk7ptr90whvycncc7e4kx6 via 2 hops using 0.00001000 fee per KB
Is this ok? y
0: 2N49tbnjF1bxi7CBkB6QeFuY5GV9gRPgFiJ -> mgHhZh2tTMFzgcikYCve6N8fKPsHgQdfF6 (0.01000455) - e5d6b96e85494c19a46b8260336a57157ffed8686a459ffdcb4ce12212e06387
Preparing rest of transactions...
1: mgHhZh2tTMFzgcikYCve6N8fKPsHgQdfF6 -> tb1qnmplzth603jf4dhkyk7ptr90whvycncc7e4kx6 (0.01000130) - add4eb1dab7b508eb80bd064bc71750d9e5c4f795978289dca7781f88d3bf6cb
Initial transaction preparing took 0.542236 seconds
Sending transactions...
Sleeping for 13 seconds
error code: -26
error message:
min relay fee not met, 158 < 188 (code 66)
Terminated
kristapsk commented
Ok, there is no handling for situations with only P2PKH inputs and P2WPKH outputs (legacy P2PKH to Bech32 sends) in calc_tx_vsize().