kriswallsmith/Buzz

RFC Constructor argument order

Nyholm opened this issue · 2 comments

Nyholm commented

Currently we have:
AbstractClient::__construct(array $options, ResponseFactoryInterface $factory)

The second argument has recently been made mandatory. I think it would make sense to flit the order. Since the option array is not always used.

I propose:
AbstractClient::__construct(ResponseFactoryInterface $factory, array $options = [])

gpietoso commented

Curiosity: which RFC?

Nyholm commented

I just meant "Request For Change"