Re-implement online search

Question

Re-implement online search

McBaumwolle opened this issue 4 years ago · 30 comments

If you install BeautySearch, it automatically disables web search.

I think it was intentionally added, but it shouldn't, many people including me use it.

XPower7125 commented 2 years ago

updates?

👎2

Answer 1 · 2020-08-22T12:20:29.000Z

TL;DR: BeautySearch is incompatible with Bing Online Search.

BeautySearch is built on the fact that Windows Search UI is actually web-based application.
When you install BS, it writes a line to the HTML file of the Search web-app, forcing it to load the BeautySearch script, so we don't need to keep the Installer executable file in memory.

The file we write data to is stored in the Windows folder, but when the Bing Search is enabled, the Search app loads the web-app from Bing instead of the local one every time you open it, so we can't modify it.
The only way to force the Search app use the local web-app is to disable Bing Search, so BS is incompatible with online search.

Answer 2 · 2020-08-22T12:22:01.000Z

Okay, thanks for the info.

Answer 3 · 2020-08-22T12:31:12.000Z

Thanks for the idea, I figured out how to re-implement the web search, even how to add a custom search provider instead of Bing (Google, etc.)

Answer 4 · 2020-09-26T11:29:18.000Z

Any updates on this?

Thanks for the idea, I figured out how to re-implement the web search, even how to add a custom search provider instead of Bing (Google, etc.)

Answer 5 · 2020-09-26T15:29:39.000Z

Any updates on this?

Thanks for the idea, I figured out how to re-implement the web search, even how to add a custom search provider instead of Bing (Google, etc.)

I managed to display search results in the Search Window, but I still need to do some research to figure out how to force open the links in an external browser.

Answer 6 · 2020-10-07T07:20:59.000Z

Any updates on this?

Thanks for the idea, I figured out how to re-implement the web search, even how to add a custom search provider instead of Bing (Google, etc.)

I managed to display search results in the Search Window, but I still need to do some research to figure out how to force open the links in an external browser.

I am thrilled for this! Currently, only the missing online search is keeping me from installing your software. Keep up the good work!

Answer 7 · 2020-12-07T22:06:28.000Z

Any updates on this?

Thanks for the idea, I figured out how to re-implement the web search, even how to add a custom search provider instead of Bing (Google, etc.)

I managed to display search results in the Search Window, but I still need to do some research to figure out how to force open the links in an external browser.

very excited to hear this! I like having search results in the start search but I hate how bing has no dark mode so for the time being I'm using duckduckgo and would absolutely love to see it integrated into the system search menu

Answer 8 · 2021-01-19T07:36:01.000Z

Are there any new updates on this or is this feature not possible?

Thanks for the idea, I figured out how to re-implement the web search, even how to add a custom search provider instead of Bing (Google, etc.)

Answer 9 · 2021-03-09T18:39:38.000Z

Finally took the time and was able to do some additional reverse engineering - I found a way to call the function that opens a given URL, so I hope to release a new version with Google search support within a few days, depending on time.

It will also support opening some webpages inside the Search Window.
Unfortunately, some websites including Google (but I've managed to bypass it) doesn't allow embedding them in iframe, so I'm thinking on bringing an optional component, that'll render the websites instead of the Search App.

On screenshot: Google Search -> a Wikipedia page embedded in the Search Window.

Answer 10 · 2021-03-20T19:25:09.000Z

I've published a beta version with some limitations.

Answer 11 · 2021-03-21T12:43:17.000Z

I've published a beta version with some limitations.

I have tried it out. The embedded window does not fit the search section and the "search the web" button (which seems to disappear when no local results are found) has to be clicked on for online results. Hope there is a fix

Answer 12 · 2021-03-21T13:47:09.000Z

The embedded window does not fit the search section

Can you provide a screenshot, please?

Answer 13 · 2021-03-21T14:43:42.000Z

The embedded window does not fit the search section

Can you provide a screenshot, please?

Answer 14 · 2021-08-08T14:03:50.000Z

not loading

Answer 15 · 2021-08-08T15:31:04.000Z

@senolfndk Try to restart the Installer and Install it again, if it still not work, you can manually take ownership before installation: #11 (comment)

Answer 16 · 2022-02-15T12:00:54.000Z

Any news on this?

Answer 17 · 2022-02-15T12:36:20.000Z

It appears that the WebView which is embedded in Search is configured to disallow loading web pages from local network even when checknetisolation is configured, while it is needed to run a local web server which will add CORS header to Google's responses, because it will not load otherwise.
I have an idea of implementing a proxy server instead of the web server and proxy only Search App requests through it with NDIS, but it is a more complex solution.

Answer 18 · 2022-02-15T12:38:31.000Z

It appears that the WebView which is embedded in Search is configured to disallow loading web pages from local network even when checknetisolation is configured, while it is needed to run a local web server which will add CORS header to Google's responses, because it will not load otherwise. I have an idea of implementing a proxy server instead of the web server and proxy only Search App requests through it with NDIS, but it is a more complex solution.

Does this affect only Google, or web engines in general? I wouldn't mind having at least Bing tbh

Answer 19 · 2022-02-15T13:53:32.000Z

It appears that the WebView which is embedded in Search is configured to disallow loading web pages from local network even when checknetisolation is configured, while it is needed to run a local web server which will add CORS header to Google's responses, because it will not load otherwise. I have an idea of implementing a proxy server instead of the web server and proxy only Search App requests through it with NDIS, but it is a more complex solution.

Does this affect only Google, or web engines in general? I wouldn't mind having at least Bing tbh

IIRC Bing loads correctly

Answer 20 · 2022-04-01T14:41:42.000Z

IIRC Bing loads correctly

Would you consider enabling Bing search in the main release if that portion is ready while you are working on other custom search engines? The beta release is a bit outdated at this point.

Answer 21 · 2022-04-01T15:56:14.000Z

IIRC Bing loads correctly

Would you consider enabling Bing search in the main release if that portion is ready while you are working on other custom search engines? The beta release is a bit outdated at this point.

Unfortunately, looks like this is no longer possible starting with build 1904X.1618+

Answer 22 · 2022-04-01T16:04:33.000Z

IIRC Bing loads correctly

Would you consider enabling Bing search in the main release if that portion is ready while you are working on other custom search engines? The beta release is a bit outdated at this point.

Unfortunately, looks like this is no longer possible starting with build 1904X.1618+

I guess because of the new Search Highlights feature

Answer 23 · 2022-04-01T17:01:27.000Z

IIRC Bing loads correctly

Would you consider enabling Bing search in the main release if that portion is ready while you are working on other custom search engines? The beta release is a bit outdated at this point.

Unfortunately, looks like this is no longer possible starting with build 1904X.1618+

I guess because of the new Search Highlights feature

Actually, the native Bing search could be re-enabled in older versions by editing the code of the bundle's JavaScript files, but this no longer works - for some reason, network requests don't pass.
Maybe this can be solved after more thorough inspection of the scripts, but they were written in React, which makes it difficult to read without source mappings.

Answer 24 · 2022-05-17T16:18:42.000Z

Neato, I was recommended this repo by github. I have a solution currently that hooks into MS Edge instead of the Start Menu but I'd love to direct traffic your way if you get this working within the Start Menu itself.

Answer 25 · 2022-05-17T19:08:11.000Z

Neato, I was recommended this repo by github. I have a solution currently that hooks into MS Edge instead of the Start Menu but I'd love to direct traffic your way if you get this working within the Start Menu itself.

This is unlikely to help - the Search Window still uses the deprecated EdgeHTML WebView, including on the latest Insider builds of Windows 11.

The Search Application simply adds an iframe to the document that loads a mini version of Bing search, the main feature of which is the allow CORS header when sending special data in the request.

The address of the WebView itself cannot be changed, and attempts to load the iframe from Google have failed due to CORS. The only thing that can be loaded there is a special version of Google search for iframe embedding, which allows CORS, but it does not fit into this small panel, because without setting cookies or changing the User-Agent, the mobile version cannot be loaded. Other search engines, again, due to CORS, cannot be embedded in an iframe.

A good solution would be to raise a local web server that proxies requests and modifies CORS headers, but it also does not load in the iframe, because firstly, UWP security rules block WebView access to local addresses until you explicitly allow this through PowerShell (this possible to do), and secondly, the WebView itself refuses to load local addresses or addresses on the local network until the appropriate prohibition is disabled in the WebView settings in the XAML or the UI Search App code.

Changing the hosts is also useless, since all these addresses resolve to 127.0.0.1 anyway, but it would be possible to perform a trick using a proxy server that would combine a CORS proxy when requesting a specific address, which is inconvenient, since it will force you to proxy in general, all traffic, or it could be done by writing a driver for the Windows Filtering Platform or using WinDivert, which is too unreasonably tricky for this.

Maybe in a future version I'll just add a web search button to the list of results, but here is also a problem - due to CORS, I can't get the query completion list from search engines, which again loses to the standard Bing Search.

It is also important to note that when search in Bing is enabled, that is, not disabled in the registry, all your even unfinished search queries come to Microsoft on the Bing servers in conjunction with your Microsoft account, even if you are looking for some local file and in general don't want to search the web, regardless of your privacy settings.

Answer 26 · 2022-07-05T14:41:37.000Z

Have you considered registering a URI and having the javascript call that URI for web search? This would allow you to access local addresses as the application registered for that URI will be handling the request, not UWP.

Answer 27 · 2022-07-05T14:58:46.000Z

Have you considered registering a URI and having the javascript call that URI for web search? This would allow you to access local addresses as the application registered for that URI will be handling the request, not UWP.

The Search App internal API accessible from JavaScript part provide a way to launch any executable file or URL, so it is possible to launch the default browser (not Microsoft Edge) without problems:

bsController.launchUri('https://github.com/');

There's also a very simple way of getting the search box input, but there's a problem which is not too simple to solve: we need to to inject a button to the search results - it should execute the code above, but it is pretty complicated to do since the Search UI is written with React.

Answer 28 · 2023-03-01T23:52:35.000Z

I Have Experience With React And Would Love to contribute to this project!

Answer 29 · 2023-03-02T06:16:30.000Z

well i do believe the project is open to PRs, despite the lack of a contributing.md file.