Consistent type hints
TheLevti opened this issue · 2 comments
TheLevti commented
All public methods should have consistent parameter type hints. I guess it should be int|float|string
. Some methods are missing this doc block type hints and because of this, editors and static code analyzers are complaining/marking uses with warnings/errors.
Please also check that all public methods have a correct return type hint.
Please provide the following details.
- Operating System: any
- PHP Version: any
Steps required to reproduce the problem.
- Use any static code analyzer or editor with intelisense.
- Try to pass to different functions different numeric types.
Expected Result.
- No errors/warnings etc.
Actual Result.
- Errors/warnings etc. about type miss match.