krux02/assimp

error in package

Closed this issue · 4 comments

leyaocty commented

Hi,

I found one mistake in file Types.go line-104:

func (v *Quaternion) W() float32 {
	return float32(v.x)
}

where return value shall befloat32(v.w).

BTW, I added one method for Bone in Mesh.go to get offset matrix from model with skeletal animation:

func (b *Bone) OffsetMatrix() Matrix4x4 {
	return Matrix4x4(b.mOffsetMatrix)
}

I tried it for skeletal animation loading and it looks well, so would you please update it into your package?

krux02 commented

Thanks for the reminder, I will update the package. You can also make a PR (less work for me and you will be listed as contributor ;-)

  • 😄1
krux02 commented

why did you close the issues?

krux02 commented

I don't know why you closed the issue. But I just pushed changes that implement your suggestions. If you are still interested in making a PR, there is still an easy target. You can make this package a module. This code predates the existence of modules.

leyaocty commented