Are you alive? :)
Closed this issue · 22 comments
Maybe you'll transfer this repo to me? I'll continue support and merge pull requests.
+1
+1
+1
+1
👍
👍
Alas, I am still alive. :) Sorry folks. It's been busy, and I've obviously been neglecting this. I'm leaving my current employer in the next week, so I hope to have more time for this after the new year. I'm also open to adding developers to the repo. I'll review and get back to you. You can haunt me on Twitter (@jlberglund) if I fail once again to respond.
Ok, could you please add me as a developer?
Does anyone have a good fork already?
Thank you, @jlberglund!
@kshnurov thanks for your help! A few things going forward though:
- With 3 of us collaborating, an issue or request should have at least two +1s from contributors
- Just because we get a pull request doesn't mean we should merge it
- I've created a remote development branch where I'd like changes made before pushing them to master
Here's the workflow I follow: http://www.joslynesser.com/blog/archives/2010/09/06/git-workflow-for-small-teams/ . What do you think? @spovich did I miss anything?
@jlberglund Yes, agreed on first two points. On the third point, I'm not convinced of the need for a dedicated development branch. Maybe you can convince me :)
I think the you should consider gems and continuously deployed apps as different creatures. For continuously deployed apps, I think a development branch can be useful (as indicated in the article), but for a gem with only periodic releases, I think it is ok to treat master as the latest approved features where features/bugs are branched off latest master. Then, when feature branches off of master are properly rebased, and have requisite +1's, they are merged to master. Also, I don't anticipate this to be a fast-moving project.
Gem releases are done when we think that enough bug fixes/features warrant a release. I would assume that @jlberglund will handle gem releases and update the changelog accordingly.
@spovich I agree.
The main thing for me is that development is branched off. So we can revise it that way. I don't want half-features or half-fixes on the master branch.
@jlberglund Totally! A PR needs to stand on it's own as a full feature/bugfix.
Guys, @spovich , @jlberglund , you're talking about one little gem like it's a starship for interstellar travel :) Keep it simple.
- We should have a deadline. If no one is responding for more than a week, one +1s should be enough. Other way we can wait for another 4 months, like we waited for this issue.
2 & 3. Ok!
About releases: what's wrong with releasing minor version after adding some feature? Once again, it's not a starship, we can spend half a year waiting for something we think is "enough". It's just a mailer.
@jlberglund , if you'll handle releases, can you handle them a bit quicker than this issue? :)
It's easier to contact with me by email.
@kshnurov following good development practices does not make an interstellar starship. Please avoid insulting hyperbole, that doesn't help.
If we can't get two +1's from maintainers in a reasonable time, we need new maintainers. Having said that, I like vacations and so there will be weeks when I don't respond. If responsiveness becomes a problem going forward, we can deal with that. No need for arbitrary date cutoff rules.
Regarding releases, we are saying the same thing. If there are new features or bugfixes, then we should release a gem. I assume once we clear the backlog, things will settle down. However, we first need to get 'master' squared away as things are broken right now from your merges.
@kshnurov @jlberglund Ok, I've reverted the commits that broke the tests on master, so master is passing for me now. @kshnurov please open new PR's or update those so tests are good. I'm going to add Travis so we can have better visibility on the tests.
@kshnurov if there are any features you want to push through sooner rather than later, will you open issues for them? that might help us prioritize and ensure you get the faster results you're looking for. Also, what's your email address? Thanks!
@jlberglund , I'll figure that out in a few days, we're currently integrating this gem into our app. My email is k [at] zx0.ru