bug in 1.3.4 - Cannot set property 'Growl' of undefined
ido172 opened this issue · 4 comments
ido172 commented
The last commint has a bug:
0a673cb#diff-b11a5d782842d456be48fc3932f5b1d5
in the last line of jquery.growl.js you did this change:
-}).call(this);
+}).call(undefined);
this causes a javascript error 'Cannot set property 'Growl' of undefined' in this line
this.Growl = Growl;
does not happen in 1.3.1
schmunk42 commented
@ksylvest Could you also add a tag to the repository? We're using your repo via https://github.com/fxpio/composer-asset-plugin which relies on tags.
@francoispluchino Would there be a way for fxpio/cap to fix this in another way?
francoispluchino commented
@schmunk42 You can use the @dev
flag in your dependency to use a version without tag (like "npm-asset/jquery-growl": "^1.3.5@dev"
).
ksylvest commented
@schmunk42 tagged