XML for Github PR Trigger is in <properties> block rather than <trigger>

[mellena1]

Hi @ktdreyer,

I think your code here is super cool, this is basically exactly what I've been looking for. As such, there are some things for our needs that the code currently doesn't support, so I've been looking into making additions to your code base (I mentioned that I was working on pipeline support, I've started on that!)

One interesting thing that I ran into was that all of our config files using the Github PR Builder plugin have the configuration for it under the tag of the XML file. This causes that info to be added as raw xml to the outputted yaml file under the properties list, rather than in the triggers area as yaml.

I figure this is more of a wonky thing on our side, but do you have any thoughts on whether this should be handled for or not? I don't mind implementing it if so, I just need some guidance... I'm still learning the codebase so I'm not exactly sure the best way to do that without breaking everything. It seems like it relies a lot on what its parent is, which IS properties, but I don't want it to be.

All the best,
Andrew

[mellena1]

I noticed that it is always in the properties tag in a pipeline job, so I think this goes along with getting #61. Knowing that I'll look into it some more. I don't want to mangle your code too much though, so any advice would be great :)

[mellena1]

I think I figured it out, I'll close this for now 👍 . I'll PR when I have some more stuff done :)