kube-rs/kube

Incorrect imports of `schemars` type

ralpha opened this issue · 2 comments

Current and expected behavior

Compile error on mismatched types.
The hard coded import in schema.rs file can change with feature flags.
This type changes with the preserve_order flag in schemars.

Possible solution

This line:

use std::collections::btree_map::Entry;

Should be changed to:

use schemars::MapEntry as Entry;

or just use schemars::MapEntry; and change the match lower down in the code (line 104-114).

Additional context

Transfer of issue from GREsau/okapi#109

Relevant code in schemars https://github.com/GREsau/schemars/blob/5268080b014152912a910e3fe8524c4c876407de/schemars/src/lib.rs#L306-L309

Environment

All

Configuration and features

No response

Affected crates

kube-core

Would you like to work on fixing this bug?

no

This might also be a good first issue for someone.

Ouch, good catch.