kubedl-io/kubedl

[feature request] enable FallbackToLogsOnError TerminationMessagePolicy by default

Closed this issue · 2 comments

What would you like to be added:
I think it would be better to enable FallbackToLogsOnError by default, to facilitate the debugging process.

	// TerminationMessageFallbackToLogsOnError will read the most recent contents of the container logs
	// for the container status message when the container exits with an error and the
	// terminationMessagePath has no contents.
	TerminationMessageFallbackToLogsOnError TerminationMessagePolicy = "FallbackToLogsOnError"

Why is this needed:
facilitate the debugging process.

the new introduced policy TerminationMessagePolicy will be a job-level option or replica-spec option? it means controller will fetch tailed logs from unexpected exited containers, and select the content that appears most often as the termination message?

I got you, TerminationMessagePolicy is a native filed in corev1.Container, enable it by default helps users to troubleshoot !