[feature request] Avoid environment variable based logic

Question

[feature request] Avoid environment variable based logic

Closed this issue 4 years ago · 4 comments

Now we have the logic as follows:

	serviceurl := fmt.Sprintf("%s-kubefate-%s.%s:8080", PREFIX, kubefateCR.Name, kubefateCR.Namespace)
	if os.Getenv("FATE_OPERATOR_TEST") == "true" {
		serviceurl = kubefateCR.Spec.IngressDomain
	}

It is hard to maintain. Prefer to have a CLI argument to implement it.

Answer 1 · 2020-07-02T03:59:46.000Z

/kind feature

Answer 2 · 2020-07-02T05:38:35.000Z

@owlet42 please have a look into it.

Answer 3 · 2020-07-27T11:21:29.000Z

/close
Close cuz fix on pr#18

Answer 4 · 2020-07-27T11:21:33.000Z

@LaynePeng: Closing this issue.

In response to this:

/close
Close cuz fix on pr#18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.