kubeflow/katib

Return validation errors after all fields are verified

tenzen-y opened this issue ยท 3 comments

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Currently, the katib validator returns errors once the error is found:

return admission.Errored(http.StatusBadRequest, err)

As we discussed here, to improve UX, we should return errors after all fields are verified like the training-operator: https://github.com/kubeflow/training-operator/blob/b5e23d0325005dd0ecae7d41ad6a80ba1459b275/pkg/webhooks/pytorch/pytorchjob_webhook.go#L66-L67

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]


Love this feature? Give it a ๐Ÿ‘ We prioritize the features with the most ๐Ÿ‘

ckcd commented

@tenzen-y may I take this issue please?

@tenzen-y may I take this issue please?

Sure, feel free to assign yourself with /assign.

ckcd commented

/assign