kubenav/kubenav

F-Droid build failed

linsui opened this issue · 4 comments

Describe the Bug

The inAppPurchase and play-service-auth libs are not FOSS. Could you please provide a flavor without them? Thanks!

Platform

  • Android
  • iOS

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

First update to 5.0.0 didn't seem to run any build (https://gitlab.com/fdroid/fdroiddata/-/commit/1bce2a6f14d5c5f4a917d69c4c2bc5d8b628515b). There was another "misc fix" (https://gitlab.com/fdroid/fdroiddata/-/commit/b04174143268834fe169ec528ba94ee85861675a) which build was cancelled.

Latest one "update to 5.1.0" (https://gitlab.com/fdroid/fdroiddata/-/commit/ebb1269f4591b841ac642b26e544f0aee37c5c87) has failed build pipeline (https://gitlab.com/fdroid/fdroiddata/-/jobs/7214417869):

Relevant log parts:

Configuration cache entry stored.
2024-06-28 13:29:33,709 DEBUG: Popen(['git', 'cat-file', '--batch-check'], cwd=/home/vagrant/build/host.stjin.anonaddy, universal_newlines=False, shell=None, istream=<valid stream>)
2024-06-28 13:29:33,711 INFO: Successfully built version v5.2.6 of host.stjin.anonaddy from 0b17fb06a059b67ec7e7e45aa2c5db77770ad5e0
2024-06-28 13:29:33,766 DEBUG: Checking build/host.stjin.anonaddy/app/build/outputs/apk/gplayless/release/app-gplayless-release-unsigned.apk
2024-06-28 13:29:33,777 INFO: Scanning APK with dexdump for known non-free classes.
2024-06-28 13:29:34,023 DEBUG: > /opt/android-sdk/build-tools/34.0.0/dexdump /tmp/tmp2qedcefl/classes.dex
2024-06-28 13:29:37,295 DEBUG: > /opt/android-sdk/build-tools/34.0.0/dexdump /tmp/tmp2qedcefl/classes2.dex
2024-06-28 13:29:37,517 DEBUG: > /opt/android-sdk/build-tools/34.0.0/dexdump /tmp/tmp2qedcefl/classes3.dex
2024-06-28 13:29:38,010 DEBUG: > /opt/android-sdk/build-tools/34.0.0/dexdump /tmp/tmp2qedcefl/classes4.dex
2024-06-28 13:29:40,837 DEBUG: > /opt/android-sdk/build-tools/34.0.0/dexdump /tmp/tmp2qedcefl/classes5.dex
2024-06-28 13:29:44,251 DEBUG: Problem: found class 'com/google/android/gms/wearable/Node'
2024-06-28 13:29:44,602 DEBUG: Problem: found class 'com/google/android/gms/tasks/Task'
2024-06-28 13:29:44,751 DEBUG: Problem: found class 'com/google/android/gms/wearable/MessageEvent'
2024-06-28 13:29:44,762 DEBUG: Problem: found class 'com/google/android/gms/wearable/NodeClient'
2024-06-28 13:29:44,933 DEBUG: Problem: found class 'com/google/android/gms/wearable/Wearable'
2024-06-28 13:29:45,302 CRITICAL: Found 5 problems in build/host.stjin.anonaddy/app/build/outputs/apk/gplayless/release/app-gplayless-release-unsigned.apk
2024-06-28 13:29:45,305 ERROR: Could not build app host.stjin.anonaddy: Found blocklisted packages in final apk!
2024-06-28 13:29:45,305 DEBUG: Error encountered, stopping by user request.
section_end:1719581386:step_script
section_start:1719581386:upload_artifacts_on_failure
Uploading artifacts for failed job
Uploading artifacts...
WARNING: repo/: no matching files. Ensure that the artifact path is relative to the working directory (/builds/fdroid/fdroiddata)
unsigned/: found 1 matching artifact files and directories
tmp/: found 1 matching artifact files and directories
WARNING: Upload request redirected                  location=https://gitlab.com/api/v4/jobs/7214417869/artifacts?artifact_format=zip&artifact_type=archive&expire_in=1+month new-url=https://gitlab.com
WARNING: Retrying...                                context=artifacts-uploader error=request redirected
Uploading artifacts as "archive" to coordinator... 201 Created  id=7214417869 responseStatus=201 Created token=glcbt-66
section_end:1719581388:upload_artifacts_on_failure
section_start:1719581388:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1719581389:cleanup_file_variables
ERROR: Job failed: exit code 1

Could you maybe provide a FOSS flavour that doesn't have the libraries?

Read the log @woj-tek host.stjin.anonaddy is some other app. :)

The checkupdate batches multiple apps, and if one fails then the whole pipeline fails, and worse, stops.

Autoupdate was disable for this app: https://gitlab.com/fdroid/fdroiddata/-/blob/ebb1269f4591b841ac642b26e544f0aee37c5c87/metadata/io.kubenav.kubenav.yml#L569

last checkupdate action was to take note of a new version, but not add a new buildblock: https://gitlab.com/fdroid/fdroiddata/-/commit/ebb1269f4591b841ac642b26e544f0aee37c5c87

so if a new version is fixed... we need to check it first.

HEAD still has the offending libs https://github.com/kubenav/kubenav/blob/main/pubspec.yaml#L49

Read the log @woj-tek host.stjin.anonaddy is some other app. :)

eh... clicking too fast :)

HEAD still has the offending libs https://github.com/kubenav/kubenav/blob/main/pubspec.yaml#L49

Hmm, only in_app_purchase? and play-service-auth is already gone?