kubernetes-client/python-base

load_config is printing to stdout

hterik opened this issue · 5 comments

hterik commented

In config/init.py, when calling load_config and not running in a cluster, a warning message is printed to stdout.

This utility function might be used in context where the stdout is used for other purposes and can garble such data.
Recommend use logging instead.

roycaihw commented

/assign

roycaihw commented

I think using logging is a good idea. Would you like to send a PR?

/unassign
cc @yliaog @tomplus

Some thoughts:

  1. It's a behavior change. We need to make sure we document it, and existing users are okay with this change.
  2. Let's make sure the behavior in python and python-base are consistent. I took a quick look and there aren't many places where we use print in this client.
DiptoChakrabarty commented

/assign

  • 👍1
roycaihw commented

This repo has been merged into the main python repo. We are archiving this repo. Please open a new issue in the main repo. Thanks!

/close

k8s-ci-robot commented

@roycaihw: Closing this issue.

In response to this:

This repo has been merged into the main python repo. We are archiving this repo. Please open a new issue in the main repo. Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.