kubernetes-csi/csi-driver-nfs

runOnControlPlane conflicts with hard coded tolerations

Closed this issue · 6 comments

cornfeedhobo commented

What happened:

setting controller.runOnControlPlane: true makes the controller unschedulable

What you expected to happen:

for the controller to get scheduled

cornfeedhobo commented

i guess the solution is to override tolerations, but then why even have runOnControlPlane in the first place?

I think the solution here is to either expose nodeSelector in values, or template tolerations.

janfrederik commented

I think the same issue exists for controller.runOnMaster: true.

janfrederik commented

See the related issue for the smb driver: kubernetes-csi/csi-driver-smb#861.

cornfeedhobo commented

Yeah, essentially the same problem.

Kariton commented

as already linked by others:

controller.runOnControlPlane: true results in

nodeSelector:
  node-role.kubernetes.io/control-plane: ''

but i need this for my rke2 deployment:

nodeSelector:
  node-role.kubernetes.io/control-plane: 'true'

hence i set it directly as controller.nodeSelector instead of controller.runOnControlPlane: true

controller:
  replicas: 2
  nodeSelector:
    node-role.kubernetes.io/control-plane: "true"

that way it will work for now without altering the chart.

  • 😕1