use StatefulSet and DaemonSet in example
pohly opened this issue · 2 comments
The recommended approach is to deploy the controller in a StatefulSet and the node plugin in a DaemonSet. The example should follow that recommendation, even though it is not strictly needed for a driver that only works in a single node.
It does fix one specific issue: directly creating a pod as in the current example can fail due to a race condition (kubernetes/kubernetes#67882).
/assign @xing-yang
@saad-ali: GitHub didn't allow me to assign the following users: xing-yang.
Note that only kubernetes-csi members and repo collaborators can be assigned.
For more information please see the contributor guide
In response to this:
/assign @xing-yang
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.