1.29 - External Provisioner Change
sunnylovestiramisu opened this issue · 7 comments
sunnylovestiramisu commented
Tasks
- Feature gate for provisioner specific VolumeAttributesClass change
- Add support for provision PVC with a VolumeAttributesClass
ConnorJC3 commented
/assign @ConnorJC3
sunnylovestiramisu commented
Is there a PR being submitted for review yet?
ConnorJC3 commented
@sunnylovestiramisu I was waiting for kubernetes/kubernetes#118863 to be merged first, but if you want I could create a PR based on that PR's version of the APIs.
sunnylovestiramisu commented
@ConnorJC3 feel free to create a PR ahead and get an early review ahead of the schedule :)
sunnylovestiramisu commented
FYI, the api change got separated and you can try to pull this change down locally in external-provisioner and make a change: https://github.com/kubernetes/kubernetes/pull/121104/files
ConnorJC3 commented
Hey, sorry about the slow response, I was sick for a few days. Thanks for splitting out the API change, I should be able to push my PR for review early next week.
sunnylovestiramisu commented
/cc @msau42