Adopt Kubernetes recommended labels
thetric opened this issue · 1 comments
thetric commented
This project does not use Kubernetes recommended labels, e.g. app
instead of app.kubernetes.io/name
.
- https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml#L31
- https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/csi-snapshotter/setup-csi-snapshotter.yaml#L70
What happened:
Installed the snapshot-controller.
What you expected to happen:
The components consistently use the the recommended labels.
How to reproduce it:
Deploy the snapshot-controller or csi-snapshotter
Anything else we need to know?:
n/a
Environment:
- Driver version: 6.2.1
- Kubernetes version (use
kubectl version
): 1.27 - OS (e.g. from /etc/os-release): Amazon Linux 2
- Kernel (e.g.
uname -a
): 5.10 - Install tools:
- Others:
mowangdk commented
/assign