No Windows 2004 image available
quickstar opened this issue · 13 comments
Hi
According to curl -L https://mcr.microsoft.com/v2/oss/kubernetes-csi/livenessprobe/tags/list there is no image other than the 1809 kernel for Windows available.
It would make sense to support the versions according to the official windows-os-version-support
I've hand-built an image as a workaround for Win 2004: djboris/livenessprobe:v2.2.0-7-g08ee863-2004
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Support for multi windows distro builds was added in kubernetes-csi/csi-release-tools#150, we'd need to make some changes in the Dockerfile.Windows args similar to this node-driver-registrar PR kubernetes-csi/node-driver-registrar#146
/remove-lifecycle rotten
/reopen
@msau42: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I think that the next steps are to:
- create a tag v2.4.0 (should be taken care of by @verult according to https://github.com/orgs/kubernetes-csi/projects/42), is this right @msau42?
- create a similar PR like kubernetes/k8s.io#2531 for livenessprobe that pushes the artifacts to k8s.gcr.io
I've verified that the https://github.com/kubernetes-csi/livenessprobe/releases/tag/v2.4.0 has a windows 2004 image (thanks to @verult for promoting v2.4.0 to the release repo through kubernetes/k8s.io#2578):
- I copied k8s.gcr.io/sig-storage/livenessprobe:v2.4.0 to my repo
- I checked that the windows 2004 version is in the manifest
❯ docker manifest inspect gcr.io/my-repo/livenessprobe:v2.4.0
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 738,
"digest": "sha256:8eaba6e85e08e048ace2bc3aa11dee2451a182d2f213f496439d362ee5f092fd",
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 950,
"digest": "sha256:1e456de07bf20da08a8fea0f30c5d483cc016245364253a2fcfb476fdb62202b",
"platform": {
"architecture": "amd64",
"os": "windows",
"os.version": "10.0.17763.2114"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 950,
"digest": "sha256:4f46a48db6b601d3068edbd7ff11aa9fe8b5ebc53b298ddf441a174a4d1c53db",
"platform": {
"architecture": "amd64",
"os": "windows",
"os.version": "10.0.18363.1556"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 950,
"digest": "sha256:793c03d6bf7db6f46c6541223e816fff74f8a6ab43b14908bf3de59afa24db2e",
"platform": {
"architecture": "amd64",
"os": "windows",
"os.version": "10.0.19041.1165"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 950,
"digest": "sha256:53b43af6e33ab6ce157530546266c0b26a6b84ee23f06cbd8c7180b5ac3a8d9f",
"platform": {
"architecture": "amd64",
"os": "windows",
"os.version": "10.0.19042.1165"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 738,
"digest": "sha256:8b87c3955deb435a7f68790c01fa0b6c84e7c0b7ce0c89685b7b483e11d36dad",
"platform": {
"architecture": "arm64",
"os": "linux"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 738,
"digest": "sha256:fbf9cd13e52f59c8167156a009afc8a1093345cec5a44268dbe4bb243a02e286",
"platform": {
"architecture": "ppc64le",
"os": "linux"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 738,
"digest": "sha256:da4e508b2f38b8560fe135620141ef34777a5a9ca5d09603219c6259b0aa68c4",
"platform": {
"architecture": "s390x",
"os": "linux"
}
}
]
}
/close
@mauriciopoppe: Closing this issue.
In response to this:
I've verified that the https://github.com/kubernetes-csi/livenessprobe/releases/tag/v2.4.0 has a windows 2004 image (thanks to @verult for promoting v2.4.0 to the release repo through kubernetes/k8s.io#2578):
- I copied k8s.gcr.io/sig-storage/livenessprobe:v2.4.0 to my repo
- I checked that the windows 2004 version is in the manifest
❯ docker manifest inspect gcr.io/my-repo/livenessprobe:v2.4.0 { "schemaVersion": 2, "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json", "manifests": [ { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 738, "digest": "sha256:8eaba6e85e08e048ace2bc3aa11dee2451a182d2f213f496439d362ee5f092fd", "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 950, "digest": "sha256:1e456de07bf20da08a8fea0f30c5d483cc016245364253a2fcfb476fdb62202b", "platform": { "architecture": "amd64", "os": "windows", "os.version": "10.0.17763.2114" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 950, "digest": "sha256:4f46a48db6b601d3068edbd7ff11aa9fe8b5ebc53b298ddf441a174a4d1c53db", "platform": { "architecture": "amd64", "os": "windows", "os.version": "10.0.18363.1556" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 950, "digest": "sha256:793c03d6bf7db6f46c6541223e816fff74f8a6ab43b14908bf3de59afa24db2e", "platform": { "architecture": "amd64", "os": "windows", "os.version": "10.0.19041.1165" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 950, "digest": "sha256:53b43af6e33ab6ce157530546266c0b26a6b84ee23f06cbd8c7180b5ac3a8d9f", "platform": { "architecture": "amd64", "os": "windows", "os.version": "10.0.19042.1165" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 738, "digest": "sha256:8b87c3955deb435a7f68790c01fa0b6c84e7c0b7ce0c89685b7b483e11d36dad", "platform": { "architecture": "arm64", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 738, "digest": "sha256:fbf9cd13e52f59c8167156a009afc8a1093345cec5a44268dbe4bb243a02e286", "platform": { "architecture": "ppc64le", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 738, "digest": "sha256:da4e508b2f38b8560fe135620141ef34777a5a9ca5d09603219c6259b0aa68c4", "platform": { "architecture": "s390x", "os": "linux" } } ] }/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.