kubernetes-csi/livenessprobe

Support structured logging

jcogilvie opened this issue · 6 comments

jcogilvie commented

The livenessprobe container should support structured logging when given the --log-format-json flag, like for instance the secrets-store-csi-driver does.

A simple implementation can be found here: https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/cmd/secrets-store-csi-driver/main.go#L90-L94

Kartik494 commented

I would like to give a try on this.
/assign

mauriciopoppe commented

@Kartik494 there's more info here too about kubernetes components kubernetes-csi/node-driver-registrar#228 (comment)

Kartik494 commented

@mauriciopoppe Thanks for the guidance i will take a look.

k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jcogilvie commented

/remove-lifecycle stale

bells17 commented

Hi @Kartik494 and @mauriciopoppe !

I hope this message finds you well. Is the development for the PR related to this issue, linked below, still ongoing?
#168

I noticed that there hadn't been any recent commits, so I took the liberty of creating a new PR, which you can find here:
#202.

If development on the above PR has stopped, I would appreciate it if you would take a moment to review my PR.
Thanks for your time and consideration.

  • 👍1