Upgrade dockershim to 1.10

Question

Upgrade dockershim to 1.10

Closed this issue 7 years ago · 9 comments

resouer commented 7 years ago

Update the dockershim to 1.10

Release check: https://github.com/kubernetes/kubernetes/releases

Answer 1 · 2018-03-17T02:12:12.000Z

I will do it.

Answer 2 · 2018-03-17T05:19:17.000Z

Please attention to CRI change: #279

Answer 3 · 2018-03-22T03:11:52.000Z

@liyanyanli If you will do this. You can start now, please update the vendor to v1.10.0-rc.1

And later, when 1.10.0 stable is out, update vendor again to latest stable.

Answer 4 · 2018-03-22T09:33:38.000Z

Ok, I see. thank you very much！

Answer 5 · 2018-03-26T02:34:36.000Z

@resouer Should we implement dockershim inside frakti and not rely on dockeshim of Kubernetes?

Kubernetes PR: dockershim: remove the use of kubelet's internal API

Answer 6 · 2018-03-26T02:43:24.000Z

@liyanyanli dockershim is a workaround, we can keep it for now. In next or next next release, we will not use dockershim and cooperate with containerd instead. You can help with that part if you are interested.

See: https://github.com/cncf/soc#katacontainers-support-for-containerdcri-containerd

Answer 7 · 2018-03-27T21:38:42.000Z

@liyanyanli 1.10.0 is out now. Please update the vendor to this stable release if possible.

If you have already finish the work, please just send out and we can update it to 1.10.0 stable later.

Answer 8 · 2018-03-28T02:13:38.000Z

Hi, @resouer

I have updated the vendor to 1.10.0. However, the changes made by dockershim make frakti have the following problems when compiling codes and I am trying to solve it.

example:

./frakti.go:113:41: cannot use privilegedRuntime (type *docker.PrivilegedRuntime) as type "k8s.io/frakti/pkg/runtime".RuntimeService in argument to manager.NewFraktiManager:
        *docker.PrivilegedRuntime does not implement "k8s.io/frakti/pkg/runtime".RuntimeService (wrong type for Attach method)
                have Attach(context.Context, *v1alpha2.AttachRequest) (*v1alpha2.AttachResponse, error)
                want Attach(*v1alpha2.AttachRequest) (*v1alpha2.AttachResponse, error)

I have two solutions:

Implement dockershim inside frakti
Frakti starts dockershim grpc server inside, then connects dockershim's grpc interface

What do you think? Thanks very much！

Answer 9 · 2018-03-28T17:47:35.000Z

@liyanyanli Please choose 2.

Just make frakti work like a CRI proxy. Thank you very much!