kubernetes-retired/kube-aws

Blank line in /run/systemd/system/kubelet.service for controller

cndbain opened this issue · 3 comments

In both kube-aws versions 0.13.0 and 0.14.0 a check in cloud-config-controller seems to be leaving a blank line in the /run/systemd/system/kubelet.service file that's generated for my controllers:

{{ if checkVersion ">= 1.14" .K8sVer -}}
--bootstrap-kubeconfig=/etc/kubernetes/kubeconfig/worker-bootstrap.yaml \
{{- end }}

Which then causes the controllers to not be able to start the kubelet.service.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Incorrect golang template whitespace chomping fixed