kubernetes-retired/kube-deploy

Convert Ginkgo test to standard testing framework.

Closed this issue · 3 comments

krousey commented

There are currently 3 test suites that use the Ginkgo and Gomega framework. These tests were generated from the apiserver-boot tool.

Tests needing conversion:

kube-deploy> grep -l  "github.com/onsi/" **/*.go | grep -v vendor | xargs dirname | sort -u
ext-apiserver/pkg/apis/cluster/v1alpha1
ext-apiserver/pkg/controller/cluster
ext-apiserver/pkg/controller/machine
krousey commented

Just to add more details, BeforeSuite, AfterSuite, BeforeEach, and AfterEach can be eliminated by writing a test case that does setup and tear down, and running subtests from within that.

krousey commented

/assign @krousey