[VC] Experimental Scheduler Cluster type generation
christopherhein opened this issue · 5 comments
Looks as though the new cluster type is a copy of the CAPI cluster type - is that meant to be https://github.com/kubernetes-sigs/multi-tenancy/blob/master/incubator/virtualcluster/experiment/pkg/apis/cluster/v1alpha4/cluster_types.go vs https://github.com/kubernetes-sigs/cluster-api/blob/master/api/v1alpha4/cluster_types.go should we just be using these by reference. If it looks like we're getting generated files that haven't been committed when running make test.
→ git status
?? config/crds/cluster.x-k8s.io_clusters.yaml/assign @Fei-Guo
/kind support
This is intended for easy testing. Another problem is that CAPI does not provide CRD clients so that I have to generate the client manually which requires the existence of the crd yaml locally. We can clean up this later.
/close
@Fei-Guo: Closing this issue.
In response to this:
This is intended for easy testing. Another problem is that CAPI does not provide CRD clients so that I have to generate the client manually which requires the existence of the crd yaml locally. We can clean up this later.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Can we at least add the generated yaml from when you run make test so that we don't have to exclude it from other PRs?