Flakey test - TestNewRateLimitedClient
micahhausler opened this issue · 4 comments
micahhausler commented
What happened:
See #60, and this test run
What you expected to happen:
The test should pass
How to reproduce it (as minimally and precisely as possible):
Unknown
=== RUN TestNewRateLimitedClient
--- FAIL: TestNewRateLimitedClient (4.95s)
client_test.go:95: #2-2: expected "context deadline", got Get http://127.0.0.1:41511/test: dial tcp 127.0.0.1:41511: i/o timeout
FAIL
coverage: 75.0% of statements
FAIL sigs.k8s.io/aws-encryption-provider/pkg/httputil 5.035s
gyuho commented
/assign @gyuho
I can repro
{
// 20 concurrent encrypt requests should exceed 1 QPS before 10ms
// thus rate limiter returns an error
- ctxTimeout: 10 * time.Millisecond,
+ ctxTimeout: 100 * time.Microsecond,
qps: 1,
burst: 1,
reqs: 20,micahhausler commented
Fixed in #62
micahhausler commented
/close
k8s-ci-robot commented
@micahhausler: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.