kubernetes-sigs/aws-fsx-csi-driver

extraTags not working

vale21 opened this issue · 9 comments

vale21 commented

/kind bug

What happened?

I am configuring extraTags in the my Storage class, following the sample code of this repo:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: lustre
allowVolumeExpansion: true
allowedTopologies: []
mountOptions:
  - flock
  - user_xattr
parameters:
  dataCompressionType: LZ4
  deploymentType: PERSISTENT_2
  extraTags: Tag1=Value1,Tag2=Value2
  fileSystemTypeVersion: '2.12'
  perUnitStorageThroughput: '1000'
  securityGroupIds: sg-***
  subnetId: subnet-***
provisioner: fsx.csi.aws.com
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer

What you expected to happen?

I was expecting to see the 2 extra tags being applied to the automatically provisioned fsx file system. Instead, they are not there:

$ aws fsx describe-file-systems --file-system-ids fs-062fc8a4904f*****
{
    "FileSystems": [
        {
            "OwnerId": "***",
            "CreationTime": "***",
            "FileSystemId": "fs-062fc8a4904f*****",
            "FileSystemType": "LUSTRE",
            "Lifecycle": "AVAILABLE",
            "StorageCapacity": 1200,
            "StorageType": "SSD",
            "VpcId": "vpc-***",
            "SubnetIds": [
                "subnet-***"
            ],
            "NetworkInterfaceIds": [
                "eni-***",
                "eni-***"
            ],
            "DNSName": "fs-062fc8a4904f*****.fsx.***.amazonaws.com",
            "KmsKeyId": "arn:aws:kms***",
            "ResourceARN": "arn:aws:fsx:***",
            "Tags": [
                {
                    "Key": "CSIVolumeName",
                    "Value": "pvc-***"
                }
            ],
            "LustreConfiguration": {
                "WeeklyMaintenanceStartTime": "2:22:00",
                "DeploymentType": "PERSISTENT_2",
                "PerUnitStorageThroughput": 1000,
                "MountName": "aupibbmv",
                "CopyTagsToBackups": false,
                "DataCompressionType": "LZ4",
                "LogConfiguration": {
                    "Level": "DISABLED"
                }
            },
            "FileSystemTypeVersion": "2.12"
        }
    ]
}

How to reproduce it (as minimally and precisely as possible)?

Deploy the storage class above in EKS and craete a container that provisions a PVC using that Storage Class

Anything else we need to know?:

Environment

  • EKS
  • Kubernetes version (use kubectl version): v1.22.15-eks-fb459a0
  • Driver version: helm chart v1.4.4, app v0.8.3
vale21 commented

Hello. Any update on this, please?

olemarkus commented

Is that supposed to work?

vale21 commented

Well, the example here makes me think that it should work: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/tree/master/examples/kubernetes/dynamic_provisioning

The description is pretty clear:

extraTags (Optional) - Tags that will be set on the FSx resource created in AWS, in the form of a comma separated list with each tag delimited by an equals sign (example - "Tag1=Value1,Tag2=Value2") . Default is a single tag with CSIVolumeName as the key and the generated volume name as it's value.

olemarkus commented

That feature was added in 0.9.0 by the looks of it.

jacobwolfaws commented

@vale21 Have you tested this on the v0.9.0 image? Changes made in master are only included in the csi driver once there's a new release, which can sometimes several weeks, so what you see in the master branch might not line up with what's in the latest image. A way to confirm what's in the latest image is by viewing the latest branch, which in this case is release-0.9.

vale21 commented

I will test it and I will comment here. Thank you very much.

vale21 commented

With version 0.9.0 (Helm chart 1.5.0) this bug is solved. Thanks

  • 🎉1
jacobwolfaws commented

/close

k8s-ci-robot commented

@jacobwolfaws: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.