kubernetes-sigs/e2e-framework

Make --labels check if any of the labels exists, not all

pranavb23 opened this issue · 8 comments

pranavb23 commented

Currently the --labels and --skip-labels flag will create a map[string][]string and based on the key and value pairs ,decide whether a feature is to be run or not.

The problem is that if I run using --labels "key1=value1,key2=value2" with the below features

f1 := features.New(....).WithLabel("key1","value1").Assess("something one", ... ).Feature()

f1 := features.New(....).WithLabel("key2","value2").Assess("something two", ... ).Feature()

testenv.Test(t,f1,f2)

Neither of the tests run.

  • f1 will not run as it does not have key2=value2
  • f2 will nto run as it does not have key1=value1

What I would expect is for the framework to check if any of the passed labels exist , in this case it would run both.

This behaviour is weird given that for --skip-labels , it skips based on the existence of any single label.

Not sure if we should modify the behaviour of --labels or have another flag for this situation ( the latter is probably the better idea )

I can have a PR ready soon if people agree.

harshanarayana commented

@pranavb23 This sounds like a fair ask in terms of what the behaviour should be. It also aligns with how other frameworks like Ginkgo handles label based filter (Though their version of filtering is a little more sophisticated)

@vladimirvivien What do you think about this requested behavior with regards to --labels option?

vladimirvivien commented

@harshanarayana @pranavb23
Agreed with this ask. It should be an or'd operation not and.

👍

k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

vladimirvivien commented

/remove-lifecycle stale

k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.