kubernetes-sigs/image-builder

`make validate-nutanix-all` failing

mboersma opened this issue · 5 comments

What steps did you take and what happened:

The validation check has been failing in PRs recently due to some misconfiguration with nutanix. You can check recent PRs for an example, or run this command:

docker run registry.k8s.io/scl-image-builder/cluster-node-image-builder-amd64:v0.1.18 validate-nutanix-all
...
Error: Failed to prepare build: "nutanix"

4 error(s) occurred:

* missing nutanix_endpoint
* missing cluster_name
* missing subnet in vm_nics 1
* missing nutanix_password


make: *** [Makefile:585: validate-nutanix-ubuntu-2004] Error 1
make: Leaving directory '/home/matt/projects/image-builder/images/capi'

What did you expect to happen:

All targets should validate without errors.

/kind bug

Looks like it was this change released in v0.8.0

Maybe we should pin to v0.7.1 for now?

I've opened #1256 to pin the version instead of removing the test.

tuxtof commented

@AverageMarcus why this test is launched as there is no nutanix platform behind fo launch a full e2e test

i have another PR who is coming who will pin the version to 0.8.x to use some new feature of the nutanix packer plugin

tuxtof commented

if you don't want to disable the test , i prefer to set default value , to validate the check

If you can get a PR up with those required values etc added that'd be awesome! I didn't know enough about the platform to know what was needed so easiest was just to pin to what we were using before :)