kubernetes-sigs/image-builder

Don't install azure client by default

mboersma opened this issue · 7 comments

mboersma commented

What steps did you take and what happened:

When building images for Azure (that is, running make build-azure-<foo>), the az command-line client is installed on each Linux (and soon, Windows) image.

What did you expect to happen:

The az client is convenient for development and troubleshooting, but isn't appropriate for production images. This should be an option that must be turned on explicitly.

Anything else you would like to add:

See also #1326

/kind bug

AverageMarcus commented

The az client will be needed if uploading the images to an image gallery wont it?
Isn't it needed to perform an az login prior to running the Make target? (At least that's what we've needed to do when using the container image)

mboersma commented

You do need az to login before running the related make targets, but that's a requirement for the build host, not on the images themselves. The build requirement is handled by the ensure-az-cli.sh script called by make deps-azure, but there are also ansible tasks that install az on the node images that image-builder creates.

I don't think there's a need for az on the node images. I grepped for uses of it to reassure myself it wasn't being called by some ansible script or systemd unit, but I may have missed something–please let me know if I did!

AverageMarcus commented

Oh sorry, I was confusing including it in the Docker image with in the final VM image. Ignore me 😄

  • ❤️1
willie-yao commented

/priority backlog

k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mboersma commented

/assign

mboersma commented

/remove-lifecycle stale